fix #3501 flakey test #3593
Merged
fix #3501 flakey test #3593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3501 for real this time!
With help from Arman, we figured out the problem I mentioned in my comment on the parent issue, where it looked like
unsafeToFutureCancelablewas failing before the release task was even enqueued. What's actually happening is that when the double check onalivefails, we try to cancel the task by submitting the cancellation to the dispatcher as a new task. It was the cancellation that was failing immediately because we'd already started the release process.Short term (this pr): adding a small sleep as part of the task before the release ensures that we finish the task and don't get caught trying to cancel with an already shut-down dispatcher. This should resolve the flake.
Longer term: Arman and I have been chatting about a way to possibly change the enqueueing so that we don't need the double-check on alive. If we figure that out, then it would remove that race condition for good :)