Hotswap#get scaladoc/impl mismatch

[durban]

The scaladoc of Hotswap#get says that "The returned resource is guaranteed to be available for the duration of the returned resource". I don't think this is true: if the whole Hotswap is finalized, the "returned resource" will be finalized too (here:

cats-effect/std/shared/src/main/scala/cats/effect/std/Hotswap.scala

Line 116 in a6c5b15

case Acquired(_, finalizer) => finalizer

).

I think either the scaladoc or the implementation should be changed. (Probably the scaladoc, although I've never used Hotswap.)

[armanbilge]

Thanks, that's actually a bug. We should make sure to acquire an exclusive lock before finalizing.

[durban]

Fixed by #3841.