-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arbitrary[CIString] is extremely slow in v1.4.0 #442
Comments
Here's an example of code that could benefit from a |
Thanks @rossabaker! |
@rossabaker it looks like the build failed for that release… 😢 |
Should be fixed as 1.4.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
Arbitrary[CIString]
instance published in case-insensitive-testkitv1.4.0
is extremely slow. Running theMonoidTests[Map[CIString, String]].monoid
tests from cats-laws takes 4–5 minutes on my computer withv1.4.0
. This was fixed in 7f27b01, and using the snapshot published when that was merged improves the runtime on those law tests to 3–4 seconds.Could we publish a
v1.4.1
with that change (and possibly everything up to the Scala Native 0.5 update in #431)? I think it would be tagged on either 713ccf0 (because that's the merge commit for 7f27b01) or 12875f1 (because that's the merge immediately preceding #431).The text was updated successfully, but these errors were encountered: