Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch directory-1.3.1.1 #53

Open
rpeszek opened this issue Sep 3, 2017 · 6 comments
Open

Patch directory-1.3.1.1 #53

rpeszek opened this issue Sep 3, 2017 · 6 comments

Comments

@rpeszek
Copy link
Contributor

rpeszek commented Sep 3, 2017

This is related to #42 since directory-1.3.1.1 tries to install unix-2.7.2.2 and that fails.

OS-X Sierra
I am at current head commit on eta master

Ankh-Morpork:eta rpeszek$ git rev-parse HEAD
1dbe87b19f815ba12ec33f558cb7b572a74e03c1

the log:

Resolving dependencies...
Configuring unix-2.7.2.2...
Building unix-2.7.2.2...
Failed to install unix-2.7.2.2
...
@rpeszek
Copy link
Contributor Author

rpeszek commented Sep 3, 2017

This is a test project that will fail with etlas install --dependencies-only
It has directory as the only package dependency.

https://github.com/rpeszek/eta-hackage-build-test/tree/eta-hackage-issue-53

@rpeszek
Copy link
Contributor Author

rpeszek commented Sep 3, 2017

The fix could be as simple as correcting
directory >= 1.3.0.0 && <= 1.3.10
to
directory >= 1.3.0.0 && <= 1.3.1.0
see the readme file

@rpeszek rpeszek changed the title directory package is listed as converted but it does not build latest directory package is listed but it does not build Sep 3, 2017
@rahulmutt
Copy link
Member

Can you send a PR to fix the README? You're also welcome to apply the older version patch onto the new version and see if that fixes the build for the latest version.

@rpeszek
Copy link
Contributor Author

rpeszek commented Sep 3, 2017

@rahulmutt I will do (tomorrow), I noticed the package version issue after I created this ticket.

@rpeszek
Copy link
Contributor Author

rpeszek commented Sep 4, 2017

I see the readme patch is done and readme is now fixed.
Precursory look tells me that the patching the newest 1.3.1.1 will likely be a bit of work as there were quite a few changes around previously patched code.
Note 1.3.1.1 version existed at the time of #41 so probably patching it will need to be different.

Please feel free to close this ticket. I may have a go at 1.3.1.1 some time in the future if it remains not patched.

@rahulmutt rahulmutt changed the title latest directory package is listed but it does not build Patch directory-1.3.1.1 Sep 4, 2017
@rahulmutt
Copy link
Member

I'll leave this ticket open to track the patching of directory-1.3.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants