-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting vX.X-latest as MongoDB version results in semver error on node:16
Docker image (Debian)
#734
Comments
thanks for reporting, next time please use the proper issue template (even if not all options apply) |
🎉 This issue has been resolved in version 8.11.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
@bvobart this should be fixed in 8.11.2, can you confirm? |
@hasezoey Wow that was quick, nice work, thanks for the fix!! I can indeed confirm that the issue has now been resolved with 8.11.2! Apologies for not using the issue template btw. I had first found the offending line of code in your source code, then used the hamburger menu on that line to create an issue referencing that specific line. Apparently then GitHub skips your issue template and only produces a code reference. |
Hi! According to your docs about the version config option, I should be able to use
v5.0-latest
to refer to the latest patch release of MongoDB 5.0. When I tried that locally on my own laptop, running Manjaro, I do indeed get the latest v5.0 binary (5.0.14 at the time of writing).However, when I committed and pushed this config change, my CI, running on the
node:16
Docker image, produced the following error:I believe this refers to this line of code. Note that a similar check occurs in the same function several lines below and might also occur more often in this file, I didn't check.
https://github.com/nodkz/mongodb-memory-server/blob/ee9b710ca5cba2557b52ac892969f0fc7f18682a/packages/mongodb-memory-server-core/src/util/MongoBinaryDownloadUrl.ts#L250
SemVer obviously finds
v5.0-latest
to be an invalid semantic version. However, your docs say it's a valid configuration option and on Manjaro (thus also Ubuntu) it downloads a proper binary just fine. Can you fix this bug?P.S. This is a great library and I love using it through
jest-mongodb
. Big thanks and kudos for your work!The text was updated successfully, but these errors were encountered: