Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing TestCase.captureOnCommitCallbacks #933

Closed
09F911029D74E35BD84156C5635688C0 opened this issue Apr 25, 2022 · 1 comment · Fixed by #1016
Closed

Missing TestCase.captureOnCommitCallbacks #933

09F911029D74E35BD84156C5635688C0 opened this issue Apr 25, 2022 · 1 comment · Fixed by #1016
Labels
bug Something isn't working

Comments

@09F911029D74E35BD84156C5635688C0
Copy link

Django 3.2 added TestCase.captureOnCommitCallbacks() context manager but this typing package is missing annotations for it.

https://github.com/django/django/blob/stable/3.2.x/django/test/testcases.py#L1260

Checked 1.10.1, master.
@09F911029D74E35BD84156C5635688C0 09F911029D74E35BD84156C5635688C0 added the bug Something isn't working label Apr 25, 2022
@sobolevn
Copy link
Member

PR is welcome.

@lachtanek lachtanek mentioned this issue Jun 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing type for TestCase.captureOnCommitCallbacks lachtanek/django-stubs
2 participants
@sobolevn @09F911029D74E35BD84156C5635688C0