Manager.bulk_update expects fields to be Sequence[str]

[kezabelle]

The bulk_update definition for BaseManager is:

django-stubs/django-stubs/db/models/manager.pyi

Line 79 in 36002a2

def bulk_update(self, objs: Iterable[_T], fields: Sequence[str], batch_size: Optional[int] = ...) -> int: ...

Note: fields: Sequence[str]

which AFAIK is incorrect, and has already been fixed for _QuerySet in:

• fields type in bulk_update #822
• Fixes #822 #868

django-stubs/django-stubs/db/models/query.pyi

Line 83 in 36002a2

def bulk_update(self, objs: Iterable[_T], fields: Iterable[str], batch_size: Optional[int] = ...) -> int: ...

Note: fields: Iterable[str]

---

It seems to me that they should both be the same, and that for example {"a", "b", "c"} (a Set[str]) should pass on both (because internally to Django, the fields is consumed by iteration and re-cast to a list of Field instances IIRC)

[adamchainz]

Yup seems right, would you like to make a PR?

We could probably do with a test that methods are in sync between BaseManager and _QuerySet.

[q0w]

#1114 covers it

[kezabelle]

Good eye 🔍
Happy to close this as a duplicate if that PR is going to solve the issue (especially as I haven't gotten around to opening a PR myself yet; the eternal backlog 😄)

As a data point, though I think it unrelated, I encountered the typing discrepancy on a 3.2 project.