From 7ffaed3fec897ecbaec0bd6385b4ff02365b9e15 Mon Sep 17 00:00:00 2001 From: Brian Helba Date: Thu, 7 Sep 2023 19:29:32 -0400 Subject: [PATCH] Remove fake "BaseExpression.deconstruct" method This is actually provided on various Expression subclasses, but not on "BaseExpression" itself. --- django-stubs/db/models/expressions.pyi | 1 - scripts/stubtest/allowlist_todo.txt | 1 - 2 files changed, 2 deletions(-) diff --git a/django-stubs/db/models/expressions.pyi b/django-stubs/db/models/expressions.pyi index 9703acad6..c0296cd0f 100644 --- a/django-stubs/db/models/expressions.pyi +++ b/django-stubs/db/models/expressions.pyi @@ -107,7 +107,6 @@ class BaseExpression: def reverse_ordering(self) -> BaseExpression: ... def flatten(self) -> Iterator[BaseExpression]: ... def as_sql(self, compiler: SQLCompiler, connection: BaseDatabaseWrapper) -> _AsSqlType: ... - def deconstruct(self) -> tuple[str, Sequence[Any], dict[str, Any]]: ... # fake class Expression(BaseExpression, Combinable): ... diff --git a/scripts/stubtest/allowlist_todo.txt b/scripts/stubtest/allowlist_todo.txt index 329d10e2b..cb4e72e84 100644 --- a/scripts/stubtest/allowlist_todo.txt +++ b/scripts/stubtest/allowlist_todo.txt @@ -1525,7 +1525,6 @@ django.db.models.expressions.BaseExpression.contains_aggregate django.db.models.expressions.BaseExpression.contains_column_references django.db.models.expressions.BaseExpression.contains_over_clause django.db.models.expressions.BaseExpression.convert_value -django.db.models.expressions.BaseExpression.deconstruct django.db.models.expressions.BaseExpression.empty_result_set_value django.db.models.expressions.BaseExpression.get_refs django.db.models.expressions.BaseExpression.output_field