Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@ember/test] Move source of truth and make '@types/ember' the re-export #297

Closed
4 tasks
mike-north opened this issue Sep 13, 2018 · 0 comments
Closed
4 tasks
Assignees
Labels
enhancement types:core Something is wrong with the Ember type definitions

Comments

@mike-north
Copy link
Contributor

Depends on: #278
Part of quest: #250

  • Validate that we're exposing 100% of Ember public API and 0% private API
  • Types for ember should import types for @ember/test as a dependency
  • Types for @ember/test should no longer import types from ember as a dependency
  • Duplicate test coverage to ensure both API surfaces are intact
    • @types/ember tests only use import Ember from 'ember'
    • @types/ember__test tests only use import __ from '@ember/test*'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement types:core Something is wrong with the Ember type definitions
Projects
None yet
Development

No branches or pull requests

1 participant