chore: onRequest和onNotification的应拦截发生在注册的handler中

不能像sendRequest和sendNotification这么来
tyn1998 · Jul 5, 2022 · f3662ad · f3662ad
1 parent ba6aa1a
commit f3662ad
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 16 deletions.
diff --git a/packages/connection/src/common/message.ts b/packages/connection/src/common/message.ts
@@ -116,14 +116,14 @@ export function createWebSocketConnection(socket: any) {
       }
 
       // onNotification很多的，onRequest我都试不出来
-      if (prop === 'onRequest' || prop === 'onNotification') {
-        return function (...args: any) {
-          if (typeof window !== 'undefined' && window.__OPENSUMI_DEVTOOL_EVENT_SOURCE_TOKEN__) {
-            window.__OPENSUMI_DEVTOOL_EVENT_SOURCE_TOKEN__.traffic.receive([prop, ...args]);
-          }
-          return target[prop].apply(target, [...args]);
-        };
-      }
+      // if (prop === 'onRequest' || prop === 'onNotification') {
+      //   return function (...args: any) {
+      //     if (typeof window !== 'undefined' && window.__OPENSUMI_DEVTOOL_EVENT_SOURCE_TOKEN__) {
+      //       window.__OPENSUMI_DEVTOOL_EVENT_SOURCE_TOKEN__.traffic.receive([prop, ...args]);
+      //     }
+      //     return target[prop].apply(target, [...args]);
+      //   };
+      // }
       return target[prop];
     },
   });

diff --git a/packages/connection/src/node/connect.ts b/packages/connection/src/node/connect.ts
@@ -23,14 +23,14 @@ export function createSocketConnection(socket: net.Socket) {
         };
       }
 
-      if (prop === 'onRequest' || prop === 'onNotification') {
-        return function (...args: any) {
-          if (typeof window !== 'undefined' && window.__OPENSUMI_DEVTOOL_EVENT_SOURCE_TOKEN__) {
-            window.__OPENSUMI_DEVTOOL_EVENT_SOURCE_TOKEN__.traffic.receive([prop, ...args]);
-          }
-          return target[prop].apply(target, [...args]);
-        };
-      }
+      // if (prop === 'onRequest' || prop === 'onNotification') {
+      //   return function (...args: any) {
+      //     if (typeof window !== 'undefined' && window.__OPENSUMI_DEVTOOL_EVENT_SOURCE_TOKEN__) {
+      //       window.__OPENSUMI_DEVTOOL_EVENT_SOURCE_TOKEN__.traffic.receive([prop, ...args]);
+      //     }
+      //     return target[prop].apply(target, [...args]);
+      //   };
+      // }
       return target[prop];
     },
   });