Refresh custom claims from the subject when a token is refreshed

[njbarrett]

Fixes #891

Currently when you refresh a token, it does not regenerate the custom claims data. If for example data in my getJWTCustomClaims is dynamic the only way the token gets updated is with a new login.
This change will recreate the claims array properly for refreshed tokens as well.

(Apologies if this is the wrong way to do it, happy to discuss other solutions)

[mattmcdonald-uk]

This change breaks the refresh middleware flow as it requires the token not to be expired when refreshing.

If you first call $this->manager->setRefreshFlow() it appears to fix it.

A further problem is that authenticate may return false which can't be passed to getClaimsArray

[njbarrett]

Hey @mattmcdonald-uk , thanks for your comment.
So are you saying if I add $this->manager->setRefreshFlow() instead of my code, or in addition to my code, I can fix this issue properly?

[mattmcdonald-uk]

I had to make a couple of changes to get this fix working for me.

Adding a call to setRefreshFlow makes sure that tokens which can be renewed are used.

Adding a test on the call to authenticate ensures it doesn't fail if the user has disappeared and false is returned.

mattmcdonald-uk@8111ae7

[mjsarfatti]

I get an error when I try to implement this:

{
    "message": "Method [authenticate] does not exist.",
    "exception": "BadMethodCallException",
    "file": "[...]vendor/tymon/jwt-auth/src/JWT.php",
    "line": 425,
    [...]

This is because the refresh() method is declared in JWT.php, but authenticate() is in JWTAuth.php.
Am I missing something?

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[mattvb91]

@mjsarfatti stuck on exactly this issue, how do I refresh the claims? Does anyone have it working, the above doesnt work.