Don't reset blacklist expiration time #1616
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the very late response, I think this is valid point and I'm happy to add it if you would be so kind to fix the tests? If not then I will pull this down and adjust myself when I have time |
|
I've updated the tests to Does PHP < 5.6 still need to be supported? Or do you know a better way to let the tests pass? |
Merged
|
@mattmcdonald-uk I have pulled down your PR and fixed the issues here - see #1775 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a blacklisted token can be used for an infinite amount of time when using the blacklist grace period, so long as a request is made at least once every x seconds (where x is the value of
blacklist_grace_period).This change ensures that the reset time on a blacklisted token is not reset every time a request is made.