Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

natural color names #7

Open
untzag opened this issue Oct 15, 2017 · 1 comment
Open

natural color names #7

untzag opened this issue Oct 15, 2017 · 1 comment

Comments

@untzag
Copy link
Collaborator

untzag commented Oct 15, 2017

came across (this very simple project)[https://github.com/apoorvaeternity/colory] posted on reddit

made me think that maybe, as a convenience method, we should allow setting of color using natural names

@tyler314
Copy link
Owner

tyler314 commented Oct 16, 2017

We could implement this if you would like, it would just be a matter of hard coding the natural colors as variables in the class. (Recall that the ws2812 goes in GRB order)
self.red = 0xff00
self.green = 0xff0000
self.blue = 0xff
self.purple = 0x8080
But I still think we should have the option for the user to specify an exact hex color if they choose. Creating these natural colors seems like unnecessary handholding to me, and I don't see why we would do something like this guy did with the nearest_match() method since our LEDs are capable of outputting every hex value from 0x0 to 0xffffff. Limiting the user to only natural colors seems like a disadvantage to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants