From a0fb7966186d8c95bce3cef00aa333ba92cc3b0d Mon Sep 17 00:00:00 2001 From: Pete Schwamb Date: Mon, 20 Mar 2023 21:25:36 -0500 Subject: [PATCH 1/9] Point Loop submodule to main (3.2.1) --- Loop | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Loop b/Loop index 0ea36c654..01eb87693 160000 --- a/Loop +++ b/Loop @@ -1 +1 @@ -Subproject commit 0ea36c654625915d8ab8f1dc261f084f294bb898 +Subproject commit 01eb87693ffb832aa8fb92692438a986ec7270e9 From 33595d60652df23f7bca0a6eb16e34b869bff702 Mon Sep 17 00:00:00 2001 From: Pete Schwamb Date: Mon, 20 Mar 2023 22:35:35 -0500 Subject: [PATCH 2/9] Update MinimedKit --- MinimedKit | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MinimedKit b/MinimedKit index 849192656..f7b4cf5eb 160000 --- a/MinimedKit +++ b/MinimedKit @@ -1 +1 @@ -Subproject commit 84919265689737292c3a18dfa0ff9113d69a6e7d +Subproject commit f7b4cf5eb1cf916b77794dce28dc03db73d26931 From 0a2d59b2b720fc8a373ed45c1a389187d91a35e6 Mon Sep 17 00:00:00 2001 From: Pete Schwamb Date: Tue, 21 Mar 2023 09:09:41 -0500 Subject: [PATCH 3/9] Update README.md Both methods are using "github", so I think we probably want to be a little clearer on this. --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 0cdf6dfed..5a516bd51 100644 --- a/README.md +++ b/README.md @@ -1,8 +1,8 @@ # LoopWorkspace -The Loop app can be built using GitHub in a browser on any computer or using a Mac with Xcode. +The Loop app can be built using GitHub workflows in a browser on any computer or using a Mac with Xcode. -* Non-developers may prefer the GitHub method +* Non-developers may prefer the GitHub workflow method * Developers or Loopers who want full build control may prefer the Mac/Xcode method ## GitHub Build Instructions From 433d4d6e21cc7f5791ffb3e15ab0cfbb80bccca2 Mon Sep 17 00:00:00 2001 From: Pete Schwamb Date: Tue, 21 Mar 2023 09:11:00 -0500 Subject: [PATCH 4/9] Update README.md --- README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 5a516bd51..3cfecd8e4 100644 --- a/README.md +++ b/README.md @@ -1,9 +1,9 @@ # LoopWorkspace -The Loop app can be built using GitHub workflows in a browser on any computer or using a Mac with Xcode. +The Loop app can be built using GitHub workflows in the cloud from a browser on any computer or using a Mac with Xcode. -* Non-developers may prefer the GitHub workflow method -* Developers or Loopers who want full build control may prefer the Mac/Xcode method +* Non-developers may prefer the GitHub workflow method, which does not require a mac. +* Developers or Loopers who want full build control may prefer the local Mac/Xcode method. ## GitHub Build Instructions From 9f1fd6f044bdc9f9a155dbb6a2812cf3228bfac5 Mon Sep 17 00:00:00 2001 From: Daniel Kimsey <90741+dekimsey@users.noreply.github.com> Date: Tue, 21 Mar 2023 16:10:31 -0500 Subject: [PATCH 5/9] Add tag/branch name to build step This exposes the name of the branch or tag that the Build Loop step is running. This helps show users what is being built (and thus a history) in the GitHub Actions view. --- .github/workflows/build_loop.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build_loop.yml b/.github/workflows/build_loop.yml index 26ee8c1ed..abd7d4f2f 100644 --- a/.github/workflows/build_loop.yml +++ b/.github/workflows/build_loop.yml @@ -1,5 +1,5 @@ name: 4. Build Loop -run-name: Build Loop +run-name: Build Loop ${{ github.ref_name }} on: workflow_dispatch: From ee50fc4a687b6e193d3c6dda0fe93694826adb0a Mon Sep 17 00:00:00 2001 From: Pete Schwamb Date: Mon, 24 Apr 2023 16:38:07 -0500 Subject: [PATCH 6/9] Bump Loop rev to 3.2.2 --- Loop | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Loop b/Loop index 01eb87693..befcbcbe6 160000 --- a/Loop +++ b/Loop @@ -1 +1 @@ -Subproject commit 01eb87693ffb832aa8fb92692438a986ec7270e9 +Subproject commit befcbcbe6733e52b315cb29904f7893e39da3514 From 279e6c525c69e815444fea8c7c8d9f09f4f8fbd0 Mon Sep 17 00:00:00 2001 From: Pete Schwamb Date: Tue, 19 Sep 2023 15:12:52 -0500 Subject: [PATCH 7/9] Fixes for building on Xcode 15. Loop 3.2.3 --- Loop | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Loop b/Loop index befcbcbe6..c6b058b42 160000 --- a/Loop +++ b/Loop @@ -1 +1 @@ -Subproject commit befcbcbe6733e52b315cb29904f7893e39da3514 +Subproject commit c6b058b4276681600979aaeba518c635f06ac135 From 81a3d9b03305a4b2a844bd6bac14a14f27626fef Mon Sep 17 00:00:00 2001 From: bjornoleh <63544115+bjornoleh@users.noreply.github.com> Date: Sun, 10 Dec 2023 15:56:36 +0100 Subject: [PATCH 8/9] Sync the GitHub runner clock with the Windows time server (#99) Adding a step to workflow jobs that interface Apple servers, as a workaround for build issues caused by runner clocks being out of sync. See https://github.com/actions/runner issue number 2996 for details. name: Sync clock run: sudo sntp -sS time.windows.com Added to the following workflows / jobs: validate_secrets.yml / validate-fastlane-secrets add_identifiers.yml / identifiers build_loop.yml / build create_certs.yml / certificates --- .github/workflows/add_identifiers.yml | 6 +++++- .github/workflows/build_loop.yml | 4 ++++ .github/workflows/create_certs.yml | 6 +++++- .github/workflows/validate_secrets.yml | 4 ++++ 4 files changed, 18 insertions(+), 2 deletions(-) diff --git a/.github/workflows/add_identifiers.yml b/.github/workflows/add_identifiers.yml index 62a2b543f..e780f9c97 100644 --- a/.github/workflows/add_identifiers.yml +++ b/.github/workflows/add_identifiers.yml @@ -23,7 +23,11 @@ jobs: # Patch Fastlane Match to not print tables - name: Patch Match Tables run: find /usr/local/lib/ruby/gems -name table_printer.rb | xargs sed -i "" "/puts(Terminal::Table.new(params))/d" - + + # Sync the GitHub runner clock with the Windows time server (workaround as suggested in https://github.com/actions/runner/issues/2996) + - name: Sync clock + run: sudo sntp -sS time.windows.com + # Create or update identifiers for app - name: Fastlane Provision run: fastlane identifiers diff --git a/.github/workflows/build_loop.yml b/.github/workflows/build_loop.yml index abd7d4f2f..c759354ad 100644 --- a/.github/workflows/build_loop.yml +++ b/.github/workflows/build_loop.yml @@ -33,6 +33,10 @@ jobs: - name: Patch Match Tables run: find /usr/local/lib/ruby/gems -name table_printer.rb | xargs sed -i "" "/puts(Terminal::Table.new(params))/d" + # Sync the GitHub runner clock with the Windows time server (workaround as suggested in https://github.com/actions/runner/issues/2996) + - name: Sync clock + run: sudo sntp -sS time.windows.com + # Build signed Loop IPA file - name: Fastlane Build & Archive run: fastlane build_loop diff --git a/.github/workflows/create_certs.yml b/.github/workflows/create_certs.yml index 82961983c..e0a29af48 100644 --- a/.github/workflows/create_certs.yml +++ b/.github/workflows/create_certs.yml @@ -23,7 +23,11 @@ jobs: # Patch Fastlane Match to not print tables - name: Patch Match Tables run: find /usr/local/lib/ruby/gems -name table_printer.rb | xargs sed -i "" "/puts(Terminal::Table.new(params))/d" - + + # Sync the GitHub runner clock with the Windows time server (workaround as suggested in https://github.com/actions/runner/issues/2996) + - name: Sync clock + run: sudo sntp -sS time.windows.com + # Create or update certificates for app - name: Create Certificates run: fastlane certs diff --git a/.github/workflows/validate_secrets.yml b/.github/workflows/validate_secrets.yml index 70401888c..28ce8d595 100644 --- a/.github/workflows/validate_secrets.yml +++ b/.github/workflows/validate_secrets.yml @@ -10,6 +10,10 @@ jobs: - name: Checkout Repo uses: actions/checkout@v3 + # Sync the GitHub runner clock with the Windows time server (workaround as suggested in https://github.com/actions/runner/issues/2996) + - name: Sync clock + run: sudo sntp -sS time.windows.com + # Validates the repo secrets - name: Validate Secrets run: | From 96772ebd57fcc6dfee67a29f18d67589a20e500d Mon Sep 17 00:00:00 2001 From: Marion Barker Date: Mon, 29 Apr 2024 19:17:07 -0700 Subject: [PATCH 9/9] Update the yml files to meet Xcode 15 and Node 20 requirements (#124) * update for Xcode 15, even in comments, and node 20 in actions * bump up to macos-14 and Xcode 15.3, now available --- .github/workflows/add_identifiers.yml | 8 ++------ .github/workflows/build_loop.yml | 8 ++++---- .github/workflows/create_certs.yml | 8 ++------ .github/workflows/validate_secrets.yml | 4 ++-- 4 files changed, 10 insertions(+), 18 deletions(-) diff --git a/.github/workflows/add_identifiers.yml b/.github/workflows/add_identifiers.yml index e780f9c97..fd8e871da 100644 --- a/.github/workflows/add_identifiers.yml +++ b/.github/workflows/add_identifiers.yml @@ -10,15 +10,11 @@ jobs: identifiers: needs: secrets - runs-on: macos-12 + runs-on: macos-14 steps: - # Uncomment to manually select latest Xcode if needed - #- name: Select Latest Xcode - # run: "sudo xcode-select --switch /Applications/Xcode_13.0.app/Contents/Developer" - # Checks-out the repo - name: Checkout Repo - uses: actions/checkout@v3 + uses: actions/checkout@v4 # Patch Fastlane Match to not print tables - name: Patch Match Tables diff --git a/.github/workflows/build_loop.yml b/.github/workflows/build_loop.yml index c759354ad..697c291b5 100644 --- a/.github/workflows/build_loop.yml +++ b/.github/workflows/build_loop.yml @@ -17,15 +17,15 @@ jobs: build: needs: secrets - runs-on: macos-12 + runs-on: macos-14 steps: # Uncomment to manually select latest Xcode if needed - name: Select Latest Xcode - run: "sudo xcode-select --switch /Applications/Xcode_14.1.app/Contents/Developer" + run: "sudo xcode-select --switch /Applications/Xcode_15.3.app/Contents/Developer" # Checks-out the repo - name: Checkout Repo - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: submodules: recursive @@ -61,7 +61,7 @@ jobs: # Upload IPA and Symbols - name: Upload IPA and Symbol artifacts - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: build-artifacts path: | diff --git a/.github/workflows/create_certs.yml b/.github/workflows/create_certs.yml index e0a29af48..f41170155 100644 --- a/.github/workflows/create_certs.yml +++ b/.github/workflows/create_certs.yml @@ -10,15 +10,11 @@ jobs: certificates: needs: secrets - runs-on: macos-12 + runs-on: macos-14 steps: - # Uncomment to manually select latest Xcode if needed - #- name: Select Latest Xcode - # run: "sudo xcode-select --switch /Applications/Xcode_13.0.app/Contents/Developer" - # Checks-out the repo - name: Checkout Repo - uses: actions/checkout@v3 + uses: actions/checkout@v4 # Patch Fastlane Match to not print tables - name: Patch Match Tables diff --git a/.github/workflows/validate_secrets.yml b/.github/workflows/validate_secrets.yml index 28ce8d595..f098db0cf 100644 --- a/.github/workflows/validate_secrets.yml +++ b/.github/workflows/validate_secrets.yml @@ -4,11 +4,11 @@ on: [workflow_call, workflow_dispatch] jobs: validate: - runs-on: macos-12 + runs-on: macos-14 steps: # Checks-out the repo - name: Checkout Repo - uses: actions/checkout@v3 + uses: actions/checkout@v4 # Sync the GitHub runner clock with the Windows time server (workaround as suggested in https://github.com/actions/runner/issues/2996) - name: Sync clock