Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use original cbor to define inline datum hash #538

Merged
merged 1 commit into from
Feb 4, 2023

Conversation

scarmuega
Copy link
Member

@scarmuega scarmuega commented Feb 4, 2023

To define the hash of an inline datum, Oura was re-encoding the value and computing the corresponding hash. The problem with this approach is that little nuances of non-deterministic CBOR encoding was yielding different hashes from the ones found on-chain.

This PR fixes the issue by upgrading upstream Pallas lib which includes a way to access the original CBOR txpipe/pallas#221

By having access to the original CBOR, we compute the hash using the correct data.

@scarmuega scarmuega merged commit febe75c into main Feb 4, 2023
@scarmuega scarmuega deleted the fix/inline-datum-hash branch February 4, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant