Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Introduce stateful cursor #116

Merged
merged 7 commits into from
Feb 2, 2022
Merged

feat: Introduce stateful cursor #116

merged 7 commits into from
Feb 2, 2022

Conversation

scarmuega
Copy link
Member

closes #86

@scarmuega scarmuega requested review from rvcas and pavlix February 2, 2022 00:16
@scarmuega scarmuega marked this pull request as ready for review February 2, 2022 00:16
rvcas
rvcas reviewed Feb 2, 2022
View reviewed changes
src/utils/cursor.rs
pub(crate) struct FileStorage(FileConfig);

// TODO: over-engineering a little bit here, leaving room for other
// types of cursor persistence (probably Redis)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smart

@mark-stopka mark-stopka merged commit 5d57a76 into main Feb 2, 2022
@mark-stopka mark-stopka deleted the feat/chain-cursor branch February 2, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvcas rvcas rvcas approved these changes

@pavlix pavlix Awaiting requested review from pavlix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Implement stateful cursor
3 participants
@scarmuega @rvcas @mark-stopka