Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServiceMonitor in different namespace #148

Open
peske opened this issue Dec 23, 2024 · 1 comment · May be fixed by #149
Open

ServiceMonitor in different namespace #148

peske opened this issue Dec 23, 2024 · 1 comment · May be fixed by #149

Comments

@peske
Copy link

peske commented Dec 23, 2024

Currently, metrics.serviceMonitor configuration is very simple, and does not allow setting the namespace. Note that ServiceMonitor resources are in many environments deployed in a namespace where Prometheus lives (i.e. monitoring), not in the namespace where the app is deployed. For this reason adding metrics.serviceMonitor.namespace would be very useful.
peske added a commit to peske/docker-registry.helm that referenced this issue Dec 23, 2024
@peske
option to set ServiceMonitor namespace
f46a790 
Fixes: twuni#148
Signed-off-by: Fat Dragon <[email protected]>
peske added a commit to peske/docker-registry.helm that referenced this issue Dec 23, 2024
@peske
option to set ServiceMonitor namespace
f1791d0 
Fixes: twuni#148
Signed-off-by: Aleksandar Pesic <[email protected]>
@peske peske linked a pull request Dec 23, 2024 that will close this issue
Open
@peske
Copy link
Author

peske commented Dec 23, 2024

I've followed put-up or shut up philosophy, and created PR...

peske added a commit to peske/docker-registry.helm that referenced this issue Dec 23, 2024
@peske
option to set ServiceMonitor namespace
052e05e 
Fixes: twuni#148
Signed-off-by: Aleksandar Pesic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

option to set ServiceMonitor namespace peske/docker-registry.helm
1 participant
@peske