Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STATIC_ROOT set to wrong variable #83

Open
zlalanne opened this issue Mar 10, 2014 · 1 comment
Open

STATIC_ROOT set to wrong variable #83

zlalanne opened this issue Mar 10, 2014 · 1 comment

Comments

@zlalanne
Copy link

In the base.py settings STATIC_ROOT is set to normpath(join(SITE_ROOT, 'assets')), when I think it really should be normpath(join(SITE_ROOT, 'static')). The STATICFILES_DIRS refers to a "static" folder not an "assets" folder.

@mhulse
Copy link

mhulse commented Jan 7, 2015

👍

On page 24:

TIP: Conventions For Static Media Directory Names

In the example above, we follow the official Django documentation's convention of using /static for the (non-user-generated) static media directory

If you find this confusing, there's no harm in calling it assets/ or site_assets/instead. Just remember to update your STATICFILES_DIRS setting appropriately.

I could not find much else in the doc refering to collectstatic or static. I'd kinda like to know why it's suggested to have static file collection dir inside the repo (vs. outside version control)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants