Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make aliases work again Closes: #93 #114

Merged
merged 4 commits into from
Dec 10, 2019
Merged

Make aliases work again Closes: #93 #114

merged 4 commits into from
Dec 10, 2019

Conversation

flaviomartins
Copy link
Contributor

Only show usage when twurl is called without arguments.

@CLAassistant
Copy link

CLAassistant commented Mar 12, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coveralls
Copy link

coveralls commented Mar 12, 2019

Coverage Status

Coverage increased (+0.04%) to 88.548% when pulling f279bdf on flaviomartins:patch-3 into ded1136 on twitter:master.

@andypiper andypiper requested a review from dlamacchia March 12, 2019 15:18
@twitter twitter deleted a comment May 3, 2019
@twitter twitter deleted a comment May 3, 2019
@twitter twitter deleted a comment May 3, 2019
@smaeda-ks
Copy link
Collaborator

Hi @flaviomartins, Thanks for submitting this PR!
Can you update your branch (merge mater) to see if that fixes the CI test? Thanks!

@flaviomartins
Copy link
Contributor Author

Hi @smaeda-ks. Done! Seems to pass all tests now.

@smaeda-ks smaeda-ks requested review from smaeda-ks and removed request for dlamacchia December 5, 2019 09:22
Copy link
Collaborator

@smaeda-ks smaeda-ks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flaviomartins I've left some comments. Thanks!

lib/twurl/cli.rb Outdated Show resolved Hide resolved
lib/twurl/cli.rb Outdated Show resolved Hide resolved
@smaeda-ks smaeda-ks self-assigned this Dec 5, 2019
@smaeda-ks smaeda-ks added this to the Target v0.9.4 milestone Dec 5, 2019
lib/twurl/cli.rb Outdated Show resolved Hide resolved
Co-Authored-By: Shohei Maeda <[email protected]>
@smaeda-ks
Copy link
Collaborator

@flaviomartins Thanks for the additional commits! Don't worry about the test failures, that's a known issue and I just fixed it in b22bd20.

Merging this PR!

@smaeda-ks smaeda-ks merged commit 5a7cee4 into twitter:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

5 participants