You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Making assumptions about line numbers makes the code brittle, and may break in new (or patched) redis sentinel versions
Compared to redis operations (GET/SET), sentinel operations are infrequent, and don't need to be optimized.
I'm seeing errors such as the below right now (may have different line numbers)
this is happening with redis sentinel version 3.2.6 (Not 100% sure if new fields are added, or if it's due to a patch to sentinel. Will update this once I figure it out)
Also, it seems like the sentinel response parsing code (sentinel_proc_sentinel_info) doesn't pay attention to how many entries redis server sends back? (From the first glance at the code)
line_buf=mbuf_get();
if (line_buf==NULL) {
goto error;
}
/* get sentinel master num at line 3 */msg_read_line(msg, line_buf, 3); // Is this skipping the line with the number of entries in the response?if (mbuf_length(line_buf) ==0) {
log_error("read line failed from sentinel ack info when skip line not used.");
goto error;
}
The text was updated successfully, but these errors were encountered:
Making assumptions about line numbers makes the code brittle, and may break in new (or patched) redis sentinel versions
Compared to redis operations (GET/SET), sentinel operations are infrequent, and don't need to be optimized.
I'm seeing errors such as the below right now (may have different line numbers)
this is happening with redis sentinel version 3.2.6 (Not 100% sure if new fields are added, or if it's due to a patch to sentinel. Will update this once I figure it out)
Also, it seems like the sentinel response parsing code (
sentinel_proc_sentinel_info
) doesn't pay attention to how many entries redis server sends back? (From the first glance at the code)The text was updated successfully, but these errors were encountered: