Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greek modes? #20

Open
cortsf opened this issue Oct 12, 2024 · 6 comments
Open

Greek modes? #20

cortsf opened this issue Oct 12, 2024 · 6 comments

Comments

@cortsf
Copy link

cortsf commented Oct 12, 2024

It's possible to show greek modes for a given root? To achieve the equivalent of this (using pedrozath/coltrane)

$ coltrane show scale scale:Dorian tone:C representation:Text
C D E♭ F G A B♭

The --help messages of kord says:

* Any modifiers (e.g., `7`, `9`, `m7b5`, `sus4`, `dim`, `+`, `maj7`, `-maj7`, `m7b5#9`, etc.).

Not sure if "etc" includes any notation to specify modes.

@twitchax
Copy link
Owner

I'm not sure I fully understand, but you're saying you would like to be able to type C Dorian, and get that output?

@cortsf
Copy link
Author

cortsf commented Oct 12, 2024

Yep. If this is not suported and a feature request could be accepted, numbers (or roman numerals) are shorter, faster to type and nice to have as an alternative to the greek names. For example C_2 == C_Dorian, C_5 == C_Mixolydian, etc.

@twitchax
Copy link
Owner

Yeah, cool. That would be fairly trivial to implement.

If you're interested, you are welcome to contribute. Otherwise, I intend to rework the web experience for this library "soon", and I can make this enhancement at the same time.

@cortsf
Copy link
Author

cortsf commented Oct 12, 2024

Ok, I'll look the code but I can't promess to submit a PR. Not very familiar with rust.

P.S: Thanks for making kord 😃

@twitchax
Copy link
Owner

No pressure at all.

Do you have any deadlines. I may be convinced to do this earlier, lol.

@cortsf
Copy link
Author

cortsf commented Oct 12, 2024

I'll probably look at the code tomorrow but most likely I won't do it at least in the short term, if it's not very obvious how it works and how to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants