-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ion-slides will be deprecated beginning with Ionic 6 #617
Comments
@twinssbc Are there any plans to replace ion-slides with swiper ? |
+1 about the need to update ionic-slides to swiper inside the ionic2-calendar code |
+1 to replace ionic slides with swiper |
I have published a new version 1.0.1 which only relies on Swiper instead of IonSlides, feel free to give a try. Note that Swiper has become an dependency, so needs to include it in package.json explicitly. |
It works! Thanks |
@twinssbc tested and it works ok with swiper instead of ion-slides. I am just strugling not being able to display correctly the calendar component inside another swiper element ( nested ). In my case I have a component to show several calendars from same user, so used a swiper to allow browsing all user calendars. Tried with autoheight=true in swiper options and also height: 100% on parent swiper and swiper slides with no sucess. With manual override of browser console css noticed that ‘align-items: center;’ on .swiper .swiper-slides is causing the undesired behaviour, if anybody have an advise it will be welcome! |
@rbertolig When I switch from IonSlides to Swiper, I notice that the css style of some slide container changes from display: block to display:flex. So I manually force it to be display: block. Maybe I need to use some alternative way. If you could provide some simple code sample, I may help to take a look. You could just fork this. |
@twinssbc thanks for the observation!, in fact noticed the real problem in my case was the 'display:flex' default style on the new ( parent ) swiper I created in my component to browse several calendars.
|
Beginning with Ionic 6 "ion-slides" component will be deprecated (https://ionicframework.com/blog/announcing-the-ionic-framework-v6-beta/). It´s recommended to switch to SwiperJs.
The text was updated successfully, but these errors were encountered: