Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"CommonJS or AMD dependencies can cause optimization bailouts" seen during angular build #260

Open
seth-church opened this issue Apr 29, 2024 · 4 comments

Comments

@seth-church
Copy link

seth-church commented Apr 29, 2024

When building with angular 13, the following is reported:

Warning: /path/goes/here/twilio.service.ts depends on '@twilio/voice-sdk'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Note that the twilio.service.ts file contains:
import { Call, Device } from '@twilio/voice-sdk';

We were seeing this issue on the version 1 package, twilio-client. We hoped this to be fixed with the version 2 package, @twilio/voice-sdk, but apparently it's not.

@charliesantos
Copy link
Collaborator

Thanks for submitting @seth-church . Can you try importing under the esm path? See this changelog for details https://github.com/twilio/twilio-voice.js/blob/master/CHANGELOG.md#ecmascript-module-support

@seth-church
Copy link
Author

Updated the import to:
import { Call, Device } from '@twilio/voice-sdk/esm';

Now seeing: Warning: /path/goes/here/node_modules/@twilio/voice-sdk/esm/twilio/uuid.js depends on 'md5'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

@charliesantos
Copy link
Collaborator

Thanks for trying @seth-church . We'll put this under our radar.

@seth-church
Copy link
Author

seth-church commented Jul 9, 2024

After doing an angular update, seeing these warnings:
Warning: /Users/sethcall/Projects/areabookweb/node_modules/@twilio/voice-sdk/esm/twilio/call.js depends on 'events'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: /Users/sethcall/Projects/areabookweb/node_modules/@twilio/voice-sdk/esm/twilio/device.js depends on 'loglevel'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Thought you might like to be aware. Not seeing the warning about md5 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants