Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - Device.runPreflight(...) factory to take a "Device" as argument #244

Open
yanniel opened this issue Feb 9, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@yanniel
Copy link

yanniel commented Feb 9, 2024

Is your feature request related to a problem? Please describe.

It is not possible to use the PreflightTest to troubleshoot issues that arise due to the configuration of the Twilio Device. This is because the PreflightTest.Options are a narrow subset of the Device.Options.

For instance: I cannot do a PreflightTest that enforces aggressive ICE nomination.

Describe the solution you'd like

I would like the Device.runPreflight(...) factory to take aDevice as argument. Ex:

const myDevice = new Device(twilioAccessToken, {
    codecPreferences: ["opus", "pcmu"],
     dscp: true,
     maxAverageBitrate: 16000,
     maxCallSignalingTimeoutMs: 30000,
     forceAggressiveIceNomination: true,
});

const preflightTest = Device.runPreflight(myDevice); 

Describe alternatives you've considered

None.

Additional context

None.

@yanniel yanniel added the enhancement New feature or request label Feb 9, 2024
@charliesantos
Copy link
Collaborator

@yanniel thanks for submitting. Is the main reason for this feature request is because you cannot use all Device.Options when running preflight? Any other reason?

@yanniel
Copy link
Author

yanniel commented Feb 12, 2024

@yanniel thanks for submitting. Is the main reason for this feature request is because you cannot use all Device.Options when running preflight? Any other reason?

Having the Preflight test take Device.Options would be a step in the right direction. So, I'll take it if it is easier to implement :-)

That said, that is not exactly the same as having the ability to test the Device instance that's being used to take calls in a Production environment. The latter is closer to the "truth" because it operates on the same Twilio Device used in Production whereas the Preflight test is creating another Device instance under the hood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants