Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace nose (with pytest?), as it's in maintenance mode for a few years #594

Closed
rominf opened this issue Mar 29, 2022 · 1 comment · Fixed by #636
Closed

Replace nose (with pytest?), as it's in maintenance mode for a few years #594

rominf opened this issue Mar 29, 2022 · 1 comment · Fixed by #636
Labels
type: twilio enhancement feature request on Twilio's roadmap

Comments

@rominf
Copy link

rominf commented Mar 29, 2022

Issue Summary

I'm a Fedora packager for python3-twilio. I've encountered an error during the build:

ERROR: InvocationError for command could not find executable nosetests

This comes from the fact that nose is apparently required for running the tests, but is not specified in tests/requirements.txt.

The obvious solution would be simply add it there, however, it is bad to add deprecated library (see: https://nose.readthedocs.io/en/latest, https://fedoraproject.org/wiki/Changes/DeprecateNose).

My proposal is to replace this invocation with pytest. I've made a patch in Fedora, and it works fine.

@childish-sambino childish-sambino added type: community enhancement feature request not on Twilio's roadmap status: help wanted requesting help from the community labels Mar 30, 2022
@childish-sambino
Copy link
Contributor

childish-sambino commented Mar 30, 2022

Relates to #588

This issue has been added to our internal backlog to be prioritized. Pull requests and +1s on the issue summary will help it move up the backlog.

@childish-sambino childish-sambino added status: work in progress Twilio or the community is in the process of implementing and removed status: help wanted requesting help from the community labels Jan 19, 2023
@childish-sambino childish-sambino added type: twilio enhancement feature request on Twilio's roadmap and removed status: work in progress Twilio or the community is in the process of implementing type: community enhancement feature request not on Twilio's roadmap labels Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants