Fixed notification resource types #399
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed defined types according to notification resource: https://www.twilio.com/docs/notify/api/notification-resource
Fixed notification resource types
|
Looks like we're typing objects as strings everywhere. This affects other resources and is part of a generated file. I'll add a task to the backlog to fix them all. Closing since this is in generated code and would be overwritten on future releases. |
|
Fixed by #475 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed defined types according to notification resource:
https://www.twilio.com/docs/notify/api/notification-resource
*Note: first time making a public pull request. I will greatly appreciate your feedback and please let me know if I did something wrong. I will gladly fix it, I'm here to learn! Thanks