Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incomingPhoneNumbers.remove() has wrong return type in typescript. #442

Closed
jwalton opened this issue Apr 30, 2019 · 5 comments · Fixed by #479
Closed

incomingPhoneNumbers.remove() has wrong return type in typescript. #442

jwalton opened this issue Apr 30, 2019 · 5 comments · Fixed by #479
Labels
code-generation issue deals with generated code difficulty: easy fix is easy in difficulty type: bug bug in the library type: twilio enhancement feature request on Twilio's roadmap

Comments

@jwalton
Copy link

jwalton commented Apr 30, 2019

Version: Master

The JSDoc for incomingPhoneNumbers.remove() says this function returns a Promise, but .d.ts says it returns void. :(

Code Snippet

        return this.client.incomingPhoneNumbers(sms._id).remove()
        .catch(err => console.log(err)) // Property 'catch' does not exist on type 'void'
@jwalton
Copy link
Author

jwalton commented Apr 30, 2019

Same problem exists on addresses.remove().

@childish-sambino
Copy link
Contributor

Relates to #414

@jwalton
Copy link
Author

jwalton commented May 14, 2019

Why is #414 closed?

@childish-sambino
Copy link
Contributor

There's a comment in the PR. A change is needed in the code generator otherwise changes here would be overwritten on the next release.

@childish-sambino childish-sambino added code-generation issue deals with generated code difficulty: easy fix is easy in difficulty type: bug bug in the library type: twilio enhancement feature request on Twilio's roadmap labels Sep 16, 2019
@childish-sambino
Copy link
Contributor

Working on a PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-generation issue deals with generated code difficulty: easy fix is easy in difficulty type: bug bug in the library type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants