Sets not serialized by fields.List #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -59,7 +59,7 @@ def to_marshallable_type(obj): | |||
| if obj is None: | |||
| return None # make it idempotent for None | |||
|
|
|||
| if hasattr(obj, '__getitem__'): | |||
| if hasattr(obj, '__iter__'): | |||
There was a problem hiding this comment.
I don't think this change is needed. This code is used in FormattedString and Url to ensure we have a mapping that can be used with kwargs to format the string/url, and should specifically check that the object passed has dict-like behavior. Your set test passes without it.
|
Aside from the issue with to_marshallable_type this looks good to me. Let me know if there's something I'm missing in that specific part. If not, I'll merge this minus that line. Thanks for the PR! |
|
@skimbrel : you're right. I changed it thinking it was the expected behaviour but I was wrong. I reverted my change. Thanks for the review ! :) |
|
Thanks for the update! Merging. |
skimbrel
added a commit
that referenced
this pull request
Jan 14, 2014
Sets not serialized by fields.List
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Listfield can't serialize aset(). I think it should.Here is a unit test providing the proof, and an attempt to fix this issue.