Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lavalink)!: Lavalink refactor to v4 API #2322

Open
wants to merge 70 commits into
base: main
Choose a base branch
from
Open

feat(lavalink)!: Lavalink refactor to v4 API #2322

wants to merge 70 commits into from

Commits on Sep 3, 2024

  1. feat(lavalink)!: Adding updated structs and enums for v4 of lavalink

    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    9ad9051 View commit details
    Browse the repository at this point in the history

  2. feat(lavalink)!: Updating model structs. Removed old OP struct not in… 

    … the version 4 api. Fixed the example for now and updated tests
    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    d309466 View commit details
    Browse the repository at this point in the history

  3. Remove commented out code in example lavalink bot

    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    b099660 View commit details
    Browse the repository at this point in the history

  4. fix(lavalink): Fixed the play, stop, seek, pause, volume, etc stucts … 

    …for the new v4
    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    338cfa4 View commit details
    Browse the repository at this point in the history

  5. This is the first stab at figuring out the session id. I fixed the re… 

    …ady so it connects now.

Still need to get the correct session id from lavalink not the discord api
    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    a7866f1 View commit details
    Browse the repository at this point in the history

  6. fix(lavalink): Removing the session implementation and renamed the se… 

    …ssions to discord_sessions in the lavalink struct. These are seperate from the session with lavalink
    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    d52bf32 View commit details
    Browse the repository at this point in the history

  7. fix(lavalink): Fixed the lavalink v4 playerupdatestat ping field.

    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    ee4f523 View commit details
    Browse the repository at this point in the history

  8. feat(lavalink): Now can read the lavalink session in the connection t… 

    …o send the outgoing messages to. This involved reading the READY response on the websocket
    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    0534c02 View commit details
    Browse the repository at this point in the history

  9. fix(lavalink): Fixed the player track model to remove user_data since… 

    … we don't have any. untagged the loadresults. Working play functionality now
    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    b92b2f3 View commit details
    Browse the repository at this point in the history

  10. fix(lavalink): Working event op code now for trackStartEvent

    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    98e76cc View commit details
    Browse the repository at this point in the history

  11. fix(lavalink): Adding todos to the guild ids for the outgoing events … 

    …to parse
    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    5fc8850 View commit details
    Browse the repository at this point in the history

  12. fix(lavalink): Adding the guild_id as no serialize for equalizer

    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    cbf10ad View commit details
    Browse the repository at this point in the history

  13. test(lavalink): Adding a serialize test for string comparison of the … 

    …structs in lavalink
    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    1a5b5dd View commit details
    Browse the repository at this point in the history

  14. refactor(lavalink): Cleaned up tests to have a function do the string… 

    … comparision
    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    e7435e1 View commit details
    Browse the repository at this point in the history

  15. tests(lavalink): Adding a test for track_start_event

    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    1cc0047 View commit details
    Browse the repository at this point in the history

  16. tests(lavalink): The play struct and command is tested against a good… 

    … json string to lavalink
    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    c26de22 View commit details
    Browse the repository at this point in the history

  17. feat(lavalink): Working stop now. Needed to put no replace in to fals… 

    …e in the endpoint
    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    e33c8ce View commit details
    Browse the repository at this point in the history

  18. feat(lavalink): Working pause function in new v4

    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    ec43697 View commit details
    Browse the repository at this point in the history

  19. feat(lavalink): Working seek and volume now.

    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    4d87d91 View commit details
    Browse the repository at this point in the history

  20. feat(lavalink): Stop now works in v4. Refactored the node some to cha… 

    …nge the endpoints based on the event. Destroy changes the method and uri
    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    09e57fa View commit details
    Browse the repository at this point in the history

  21. test(lavalink): Adding stats tests for the stats structures

    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    b48ec2b View commit details
    Browse the repository at this point in the history

  22. refactor(lavalink): fixed the test names for the incoming to be only … 

    …deserialize. Fixed warning about missing doc
    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    a498dd9 View commit details
    Browse the repository at this point in the history

  23. feat(lavalink): Adding in support and tests for equalizer. Added a co… 

    …mmand to the basic bot to test this out as well.
    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    2c5e10e View commit details
    Browse the repository at this point in the history

  24. refactor(lavalink): moved the modules from model.rs into their own fi… 

    …les incoming.rs, and outgoing.rs
    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    c3f79de View commit details
    Browse the repository at this point in the history

  25. doc(lavalink): Updating the README with the changes of v4 and what di… 

    …d and didn't get ported forward. I added some high level context as well for new beginners since it took me awhile to find my bearings.
    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    9b75e43 View commit details
    Browse the repository at this point in the history

  26. fix(lavalink): Fixed typo in WebSocketClosedEvent with a lowercase `s… 

    …`. Updated and added a test to parse the incoming now
    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    f532c43 View commit details
    Browse the repository at this point in the history

  27. fix(lavalink): Track events now decoded correctly and the WebSocketCl… 

    …osed typo is fixed
    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    17d4a84 View commit details
    Browse the repository at this point in the history

  28. fix(lavalink): spelling errors

    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    fad0435 View commit details
    Browse the repository at this point in the history

  29. fix(lavalink): ran formater on the code

    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    a82950a View commit details
    Browse the repository at this point in the history

  30. fix(lavalink): clippy errors are now resolved

    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    7ae3b51 View commit details
    Browse the repository at this point in the history

  31. fix(lavalink): fixing the tests and minimal versions

    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    bab628c View commit details
    Browse the repository at this point in the history

  32. fix(lavalink): Fixing formatting and clippy warnings for lavalink tests

    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    dfd42ce View commit details
    Browse the repository at this point in the history

  33. fix(lavalink): Fixing the no default config of http. If that wasn't e… 

    …nabled then some structs weren't visible in the model since they were required.

Moved the Track, Exception, Severity, and TrackInfo into the correct incoming or outgoing model files
    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    38f2aaa View commit details
    Browse the repository at this point in the history

  34. refactor(lavalink): Move the guild id and no replace with helper func… 

    …tions on the enum OutgoingEvent
    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    3147e92 View commit details
    Browse the repository at this point in the history

  35. refactor(lavalink): Use Uri builder for the outgoing events instead

    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    b08ccbd View commit details
    Browse the repository at this point in the history

  36. refactor: Format code

    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    5da3c95 View commit details
    Browse the repository at this point in the history

  37. feat(lavalink): Added OutgoingEventHasNoSession for when we try to co… 

    …nnect to the api and no session was established.
    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    b0277aa View commit details
    Browse the repository at this point in the history

  38. doc(lavalink): Adding documentation to the new helper functions for o… 

    …utgoing event
    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    422cb43 View commit details
    Browse the repository at this point in the history

  39. refactor(lavalink): Adding debug tracing, spelling fix, Replacing the… 

    … unwraps with map_err to forward to user.
    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    a37e113 View commit details
    Browse the repository at this point in the history

  40. refactor(lavalink): format and clippy warnings and error cleanup

    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    25c60b6 View commit details
    Browse the repository at this point in the history

  41. fix(lavalink): Session was being taken causing broken outgoing.

    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    7ba6c16 View commit details
    Browse the repository at this point in the history

  42. feat(lavalink): Updating the todo's for the examples in the basic bot

    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    8f50b4a View commit details
    Browse the repository at this point in the history

  43. refactor(lavalink): Alphabetized the structs and enums in incoming

    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    dd66b21 View commit details
    Browse the repository at this point in the history

  44. refactor(lavalink): alphabetize enums and structs for http and model

    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    4964939 View commit details
    Browse the repository at this point in the history

  45. fix(lavalink): Remove the unnecessary rename for the serde on frame_s… 

    …tats
    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    588b4d2 View commit details
    Browse the repository at this point in the history

  46. feat(lavalink): Adding a feature flag to enable http2 support for lav… 

    …alink. default is http1
    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    2fa60e2 View commit details
    Browse the repository at this point in the history

  47. refactor(lavalink): Adding documentation to README about flag and ren… 

    …amed to lavalink-protocol-http2.
    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    e027013 View commit details
    Browse the repository at this point in the history

  48. refactor(lavalink): Use the legacy build for client on hyper and stor… 

    …e in the connection object to avoid continuously connecting / creating the client.
    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    89d472d View commit details
    Browse the repository at this point in the history

  49. fix: Spelling and formatting corrected

    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    2e78099 View commit details
    Browse the repository at this point in the history

  50. fix: Tests now pass based on new struct order

    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    9477c59 View commit details
    Browse the repository at this point in the history

  51. fix: hyper_utils missing feature flags

    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    22b6ae9 View commit details
    Browse the repository at this point in the history

  52. refactor(lavalink): Adding suggested changes based on feedback 

    Updating some grammar errors, formatting, spelling, and some code reduction.
    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    7095e46 View commit details
    Browse the repository at this point in the history

  53. refactor(lavalink): Adding new error for the failed to request over h… 

    …ttp on lavalink connection
    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    cd4906c View commit details
    Browse the repository at this point in the history

  54. fix(lavalink): Removed the optional dependencies after removing the f… 

    …eature flag `http-support`
    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    ddbd6f4 View commit details
    Browse the repository at this point in the history

  55. Use self in getters

    @vilgotf @LinuxDevon
    vilgotf authored and LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    f8d66ac View commit details
    Browse the repository at this point in the history

  56. fmt imports

    @vilgotf @LinuxDevon
    vilgotf authored and LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    99a00b7 View commit details
    Browse the repository at this point in the history

  57. Remove node session_id lock

    @vilgotf @LinuxDevon
    vilgotf authored and LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    885c4d8 View commit details
    Browse the repository at this point in the history

  58. Conditionally enable HTTP/2

    @vilgotf @LinuxDevon
    vilgotf authored and LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    a999a13 View commit details
    Browse the repository at this point in the history

  59. Make client-name const

    @vilgotf @LinuxDevon
    vilgotf authored and LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    1159372 View commit details
    Browse the repository at this point in the history

  60. Avoid leaking authorization 

    Authorization is to be redacted. In this case, the request is not that interesting so the entire event is removed
    @vilgotf @LinuxDevon
    vilgotf authored and LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    a4c7af6 View commit details
    Browse the repository at this point in the history

  61. Remove overly verbose tracing events

    @vilgotf @LinuxDevon
    vilgotf authored and LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    2510e16 View commit details
    Browse the repository at this point in the history

  62. Improve module documentation

    @vilgotf @LinuxDevon
    vilgotf authored and LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    d12aed8 View commit details
    Browse the repository at this point in the history

  63. Add no default features to deps

    @vilgotf @LinuxDevon
    vilgotf authored and LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    199190d View commit details
    Browse the repository at this point in the history

  64. Update some README documentation

    @vilgotf @LinuxDevon
    vilgotf authored and LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    3038739 View commit details
    Browse the repository at this point in the history

  65. Clippy suggestions

    @vilgotf @LinuxDevon
    vilgotf authored and LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    28c720f View commit details
    Browse the repository at this point in the history

  66. feat: Adding support for Identifier to the UpdatePlayerTrack struct 

    Added the ability to either include the identifier or the encoded track on and update. Each let you do different things for the server.
    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    9de5656 View commit details
    Browse the repository at this point in the history

  67. refactor: Updating the README for lavalink. Moved the comments to the… 

    … basic example for a bit more documentation
    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    61b8cd5 View commit details
    Browse the repository at this point in the history

  68. fix: Consistency in the capitalization of tracing statements

    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    fd521d9 View commit details
    Browse the repository at this point in the history

  69. fix: Setting the correct websocket address if TLS is enabled

    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    571355e View commit details
    Browse the repository at this point in the history

  70. Revert "fix: Setting the correct websocket address if TLS is enabled" 

    This reverts commit 1aa6b9b.
    @LinuxDevon
    LinuxDevon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    9d7ad7b View commit details
    Browse the repository at this point in the history