Add support null-coalescing operator ??
#575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address issue #319
willrowe
requested changes
Jul 9, 2018
willrowe
requested changes
Jul 9, 2018
test/test.expressions.operators.js
Outdated
|
|
||
| it("should support the null-coalescing operator for false conditions", function() { | ||
| debugger; | ||
| var test_template = twig({data: '{{ a ?? b }}'}) |
There was a problem hiding this comment.
Move the commas to the same line at the end.
test/test.expressions.operators.js
Outdated
| @@ -55,6 +55,27 @@ describe("Twig.js Expression Operators ->", function() { | |||
| }); | |||
| }); | |||
|
|
|||
| describe("?? ->", function() { | |||
| it("should support the null-coalescing operator for true conditions", function() { | |||
| var test_template = twig({data: '{{ a ?? b }}'}) | |||
There was a problem hiding this comment.
Move the commas to the same line at the end.
test/test.expressions.operators.js
Outdated
| , output_t = test_template.render({a: undefined, b: "two"}) | ||
| , output_f = test_template.render({a: null, b: "two"}); | ||
|
|
||
| output_t.should.equal( "two" ); |
There was a problem hiding this comment.
Remove spaces around strings.
test/test.expressions.operators.js
Outdated
| , output_t = test_template.render({a: "one", b: "two"}) | ||
| , output_f = test_template.render({a: false, b: "two"}); | ||
|
|
||
| output_t.should.equal( "one" ); |
There was a problem hiding this comment.
Remove spaces around strings.
|
@willrowe Want to implement Prettier and run a pass over the entire codebase + tests to standardise? |
|
@dave-irvine that would be nice, I'll add it to my list to look into. |
dave-irvine
approved these changes
Jul 9, 2018
|
Thanks! |
willrowe
pushed a commit
to willrowe/twig.js
that referenced
this pull request
May 11, 2019
* Add support null-coalescing operator `??` Address issue twigjs#319 * Add some formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address issue #319