Skip to content

Commit

Permalink
dmime: Remove unnecessary struct message members.
Browse files Browse the repository at this point in the history
  • Loading branch information
rbernon authored and julliard committed Sep 18, 2023
1 parent db9758f commit 61ebdbc
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions dlls/dmime/performance.c
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,6 @@ struct performance
struct message
{
struct list entry;
BOOL bInUse;
DWORD cb;
DMUS_PMSG pMsg;
};

Expand All @@ -91,7 +89,7 @@ static struct message *ProceedMsg(struct performance *This, struct message *cur)
SetEvent(This->hNotification);
}
list_remove(&cur->entry);
cur->bInUse = FALSE;
list_init(&cur->entry);
switch (cur->pMsg.dwType) {
case DMUS_PMSGT_WAVE:
case DMUS_PMSGT_TEMPO:
Expand Down Expand Up @@ -406,7 +404,7 @@ static HRESULT WINAPI performance_SendPMsg(IDirectMusicPerformance8 *iface, DMUS

EnterCriticalSection(&This->safe);

if (message->bInUse)
if (!list_empty(&message->entry))
hr = DMUS_E_ALREADY_SENT;
else
{
Expand All @@ -429,7 +427,6 @@ static HRESULT WINAPI performance_SendPMsg(IDirectMusicPerformance8 *iface, DMUS
if (next->pMsg.rtTime >= message->pMsg.rtTime) break;
list_add_before(&next->entry, &message->entry);

message->bInUse = TRUE;
hr = S_OK;
}

Expand Down Expand Up @@ -515,6 +512,7 @@ static HRESULT WINAPI performance_AllocPMsg(IDirectMusicPerformance8 *iface, ULO

if (!(message = calloc(1, size - sizeof(DMUS_PMSG) + sizeof(struct message)))) return E_OUTOFMEMORY;
message->pMsg.dwSize = size;
list_init(&message->entry);
*msg = &message->pMsg;

return S_OK;
Expand All @@ -532,7 +530,7 @@ static HRESULT WINAPI performance_FreePMsg(IDirectMusicPerformance8 *iface, DMUS
message = DMUS_PMSGToItem(msg);

EnterCriticalSection(&This->safe);
hr = message->bInUse ? DMUS_E_CANNOT_FREE : S_OK;
hr = !list_empty(&message->entry) ? DMUS_E_CANNOT_FREE : S_OK;
LeaveCriticalSection(&This->safe);

if (SUCCEEDED(hr))
Expand Down

0 comments on commit 61ebdbc

Please sign in to comment.