Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple phone numbers, links, and emails #4985

Closed
FelixMalfait opened this issue Apr 16, 2024 · 4 comments
Closed

Multiple phone numbers, links, and emails #4985

FelixMalfait opened this issue Apr 16, 2024 · 4 comments
Assignees

Comments

@FelixMalfait
Copy link
Member

Previous data structure

{
   email 
   phone 
   link {
      label
      url
   } 
}

Future data structure

{
   emails {
     primaryEmail 
     additionalEmails (array)
   } 
   phones {
     primaryPhone {
        number
        country
    }
    additionalPhones (json)
   }
   links {
      primaryLink {
      label
      url
      }
     additionalLinks (json) 
   } 
}

I.e. we create composite field including the current structure + an additional optional additonal array column.

In the field settings we should have an option to enable/disable multi-input

@FelixMalfait FelixMalfait added the T label Apr 16, 2024
@thaisguigon thaisguigon self-assigned this Apr 22, 2024
@Bonapara
Copy link
Member

Bonapara commented Apr 22, 2024

CleanShot 2024-04-22 at 16 21 36

Edit by Félix: Please confirm design with @Bonapara as we discussed adding something to identify the primary element vs secondary/additional items

@r0bbie
Copy link

r0bbie commented Jul 12, 2024

Was looking to request this, so very happy to see you guys are working on it :)

It's definitely an issue right now that we have duplicate entries for a lot of people if they have more than one email (like a work and personal one for example), and would be great to get these merged!

@FelixMalfait
Copy link
Member Author

FelixMalfait commented Jul 14, 2024

@r0bbie we've shipped the "multi-links" field so the hardest part is done because multi-phone number and multi-emails should be pretty similar. But unfortunately we don't have multi-emails / phone planned on the core team's roadmap so we can't give a date yet.

@Bonapara would you mind eventually closing this issue and creating 2 new issues with links to your clean Figma design for the emails + phone number? Email is probably easier than phone number (because of the composite nature, there might be an additional complexity), pointing to LINKS as a reference implementation.

@Bonapara
Copy link
Member

Closing this issue and replacing it with two dedicated issues:

Emails
#6261

Phones
#6260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants