Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around quoting issues on Windows #573

Closed
gdeest opened this issue Jan 16, 2019 · 1 comment · Fixed by #588
Closed

Work around quoting issues on Windows #573

gdeest opened this issue Jan 16, 2019 · 1 comment · Fixed by #588
Assignees

Comments

@gdeest
Copy link
Contributor

gdeest commented Jan 16, 2019

Here is the upstream ticket:

bazelbuild/bazel#7122

Potential strategies include:

  • Adding dummy spaces to trigger proper quoting.
  • Passing command-line arguments via params_file or similar (if those are still needed).
@gdeest gdeest self-assigned this Jan 16, 2019
@gdeest
Copy link
Contributor Author

gdeest commented Jan 17, 2019

I got this to work in the gd-win-quoting branch (for GHC invocations only) by dumping arguments into files. For reasons related to the following ticket:

bazelbuild/bazel#6230

I had to make a compromise in the run_ghc function: we can no longer pass multiple Args object as a list, but only a single one. Otherwise, we would have had to create as many params files as Args object, and it would have become a real mess. That is not an issue in my view, as we never used it anyway.

I have confirmed that we can still compile simple binaries on Windows (with a few minor tweaks that will be contributed in a later PR).

However, for reasons beyond my comprehension, it fails on CI for both Linux and Darwin, with Bazel complaining of multiple file declarations ­— while it works perfectly for both @nmattia and I locally, using the same nix-shell and commands as CI. @nmattia is thus gonna pick it up from here to investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant