Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent .ghc.environment flags from getting picked up when running a @repl target. #516

Open
Profpatsch opened this issue Dec 14, 2018 · 4 comments
Open

Prevent .ghc.environment flags from getting picked up when running a @repl target. #516

Profpatsch opened this issue Dec 14, 2018 · 4 comments
Labels
good first issue P3 minor: not priorized type: feature request

Comments

@Profpatsch
Copy link
Contributor

As per #470 (comment) we want to make sure that haskell/cabal#4542 does not taint our users repls with surprising behavior.
@mboes
Copy link
Member

mboes commented Dec 14, 2018

Will this happen? AFAIR Bazel runs GHCi with CWD set to a directory it controls, not the checked out tree.

@Profpatsch
Copy link
Contributor Author

Will this happen?

I haven’t checked, I just wanted to make sure the comment doesn’t get lost after #470 closes.

@Profpatsch Profpatsch added this to the REPL improvements milestone Jan 9, 2019
@mboes
Copy link
Member

mboes commented Apr 6, 2019

Can you check? That way we can close this ticket.

@mboes mboes removed this from the REPL improvements milestone Apr 6, 2019
@Profpatsch
Copy link
Contributor Author

I don’t know how to check, but according to the commit message in https://git.haskell.org/ghc.git/commit/8f3c149d94814e4f278b08c562f06fc257eb3c43 we can set GHC_ENVIRONMENT to - to disable any environment setup leaking into our runtime.

We could set it for everything in rules_haskell, builds and runtime environments.

@emilypi emilypi mentioned this issue Aug 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue P3 minor: not priorized type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mboes @Profpatsch