Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recover type safety in bindings of Foreign.R.Internal #382

Closed
facundominguez opened this issue Nov 3, 2022 · 0 comments · Fixed by #426
Closed

Recover type safety in bindings of Foreign.R.Internal #382

facundominguez opened this issue Nov 3, 2022 · 0 comments · Fixed by #426

Comments

@facundominguez
Copy link
Member

A bunch of bindings using capi FFI were changed in #379 to use ccallinstead. This does no checking of the types of the C functions which will cause undefined behavior if the C API of R is ever changed. Here is a discussion of the possible fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check C types of foreign imports tweag/HaskellR
1 participant
@facundominguez