Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetSupportedGlobalNetworkCallingCodes returns empty dictionary #56

Open
AmirSasson opened this issue Feb 27, 2018 · 2 comments
Open

GetSupportedGlobalNetworkCallingCodes returns empty dictionary #56

AmirSasson opened this issue Feb 27, 2018 · 2 comments

Comments

@AmirSasson
Copy link

AmirSasson commented Feb 27, 2018

PhoneNumberUtil phoneUtil = PhoneNumberUtil.GetInstance(); var all = phoneUtil.GetSupportedGlobalNetworkCallingCodes();
all will be an empty dictionary while it should return the full list of supported calling code metadata

@twcclegg
Copy link
Owner

It returns a Dictionary<>.KeyCollection which is a list of sorts, though it probably should be a proper List. As for the data itself, I'll look into it, in the meantime if you call GetMetadataForRegion first that will load the data and GetMetadataForRegion will return properly.

@ghost
Copy link

ghost commented May 30, 2019

I came across this issue as well, there seems to be a problem with the isNonGeoRegion flag in LoadMetadataFromFile.
I can't work out what this method is trying to do when it populates countryCodeToNonGeographicalMetadataMap, but it doesn't seem to match the behaviour of the c++ version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants