New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a script to make sure the icons are exctly the same in bootstrap-icons.json #1640

Closed

XhmikosR opened this issue Mar 25, 2023 · 1 comment · Fixed by #1657

Labels

build enhancement help wanted

Member

XhmikosR commented Mar 25, 2023 •

edited

Loading

Loop through all SVG files
Get bootstrap-icons.json object keys and sort them
Check that the result is exactly the same; if not show the diff and error out

Everything should be async like we do in our other build scripts.

So that we don't hit #1521 again in the future.

XhmikosR added enhancement help wanted build labels

Contributor

korki43 commented Mar 26, 2023

I'll try to implement this.

korki43 mentioned this issue

build: add a script to check font JSON for differences with SVGs #1657

Merged

XhmikosR closed this as completed in #1657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment