Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More concise improvements for add() and subtract() #34432

Merged
merged 5 commits into from
Jul 27, 2021
Merged

More concise improvements for add() and subtract() #34432

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4d19246
refactor(functions): add() and subtract() more concise improvements
ffoodd Jul 6, 2021
4fffa45
Merge branch 'main' into main-fod-subtract-improvements
XhmikosR Jul 8, 2021
9b86290
Merge branch 'main' into main-fod-subtract-improvements
XhmikosR Jul 25, 2021
74d4eb3
Merge branch 'main' into main-fod-subtract-improvements
mdo Jul 26, 2021
1a728d0
Merge branch 'main' into main-fod-subtract-improvements
XhmikosR Jul 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions scss/_functions.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,14 +191,6 @@ $_luminance-list: .0008 .001 .0011 .0013 .0015 .0017 .002 .0022 .0025 .0027 .003
@return $value1 + $value2;
}

@if type-of($value1) != number {
$value1: unquote("(") + $value1 + unquote(")");
}

@if type-of($value2) != number {
$value2: unquote("(") + $value2 + unquote(")");
}

@return if($return-calc == true, calc(#{$value1} + #{$value2}), $value1 + unquote(" + ") + $value2);
}

Expand All @@ -219,10 +211,6 @@ $_luminance-list: .0008 .001 .0011 .0013 .0015 .0017 .002 .0022 .0025 .0027 .003
@return $value1 - $value2;
}

@if type-of($value1) != number {
$value1: unquote("(") + $value1 + unquote(")");
}

@if type-of($value2) != number {
$value2: unquote("(") + $value2 + unquote(")");
}
Expand Down