Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4: Rip out IE compatibility mode meta tags #21483

Merged
merged 4 commits into from
Dec 31, 2016
Merged

v4: Rip out IE compatibility mode meta tags #21483

merged 4 commits into from
Dec 31, 2016

Conversation

mdo
Copy link
Member

@mdo mdo commented Dec 31, 2016

Fixes #21476.

Updates the docs, examples, and JS tests to remove the relevant <meta> tag. Also updates our docs to remove mention of some irrelevant IE8-9 business. This info will still be there in v3's docs, so we can update it later to link to things as needed.

@mdo mdo added this to the v4.0.0-alpha.6 milestone Dec 31, 2016
@IamManchanda
Copy link

IamManchanda commented Dec 31, 2016

super awesome @mdo sir
& @bardiharborow mate !!

@Quy
Copy link
Contributor

Quy commented Dec 31, 2016

introduction.md needs to be updated.

@IamManchanda
Copy link

IamManchanda commented Dec 31, 2016

Exactly @Quy .... i didn't notice.
That page was the ticket (starter template) infact so i am surprised that is not commited ?

cc /@mdo @bardiharborow
Would humbly request you to plz commit that also .... cheers 👍

@Starsam80
Copy link
Contributor

I've been wondering this for a while now (and this probably isn't the place to talk about it, I just got reminded of it because of the change adding the note about v3), but v3 status is "no more features, only critical bug fixes and documentation improvements", but every v3 issue and pull request I've seen has been closed. Just how critical are we talking here? Why not merge #21341 which seems like a fairly big problem to some people? And why not merge pull requests like #21065 that just add a documentation improvement?

@mdo
Copy link
Member Author

mdo commented Dec 31, 2016

@Starsam80 I'm labelling all those issues as they get closed. Anything I can come back to when v4 is released, I'll come back to. Otherwise, just talking about mental load and balancing work, life, and OSS, I can only focus on one major code version at a time. Trying to do both was no good for anyone for far too long. 😞

@Quy
Copy link
Contributor

Quy commented Dec 31, 2016

...and this Forcing Internet Explorer to use its latest rendering mode (read more) ;)

@IamManchanda
Copy link

IamManchanda commented Dec 31, 2016

@Starsam80 sorry but please support mark & team on this .... dont worry we all will get back to v3 rather sooner than later .... at this time v4 should be the focus ... These coming months, we should work hard for this v4 release first and then think about anything else like v3.

@mdo
Copy link
Member Author

mdo commented Dec 31, 2016

@IamManchanda Thanks, but I appreciate @Starsam80 pushing back on that stuff. I did make some copy changes there and he's right that it's not all that accurate in how we're "maintaining" v3.

@IamManchanda
Copy link

IamManchanda commented Dec 31, 2016

Yup won't fix is the not the right choice , even i agree .... @mdo @Starsam80

Would be better to reopen those important issues or something like a temporary lock can also be a better choice for some of these issues but surely not most !!

@Starsam80
Copy link
Contributor

Or maybe a new label to show that they will be reviewed later. Maybe something like punted?

@IamManchanda
Copy link

Yup 👍 @Starsam80 .... but i guess reviewed later is also a good choice of the label..... rest on mark to decide

@mdo mdo merged commit e2b6bad into v4-dev Dec 31, 2016
@mdo mdo deleted the remove-ie-modes branch December 31, 2016 20:20
@mdo mdo mentioned this pull request Dec 31, 2016
@Studio384
Copy link

Why are these tags being removed? IE10 and IE11 still need those to make sure that they are using their respective latest rendering engine, no?


For a list of some of the browser bugs that Bootstrap has to grapple with, see our [Wall of browser bugs]({{ site.baseurl }}/browser-bugs/).

## Internet Explorer

Internet Explorer 10+ is supported, however, IE9 down is not. Please be aware that some CSS3 properties and HTML5 elements are not fully supported.
Internet Explorer 10+ is supported; IE9 down is not. Please be aware that some CSS3 properties and HTML5 elements are not fully supported in IE10, or require prefixed properties for full functionality. Visit [Can I use...](http://caniuse.com/) for details on browser support of CSS3 and HTML5 features.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, but shouldn't it say "IE9 and down is not"?

@patrickhlauke
Copy link
Member

IE10 and IE11 still need those to make sure that they are using their respective latest rendering engine, no?

no. HTML5 doctype has the exact same effect, without needing vendor-specific meta elements

alanorth added a commit to alanorth/hugo-theme-bootstrap4-blog that referenced this pull request Jan 7, 2017
Bootstrap v4 Alpha 6 removes support for IE 8 and 9 and these tags
are no longer necessary.

See: twbs/bootstrap#21483
alanorth added a commit to alanorth/hugo-theme-bootstrap4-blog that referenced this pull request Jan 8, 2017
Bootstrap v4 Alpha 6 removes support for IE 8 and 9 and these tags
are no longer necessary.

See: twbs/bootstrap#21483
alanorth added a commit to alanorth/hugo-theme-bootstrap4-blog that referenced this pull request Jan 8, 2017
Bootstrap v4 Alpha 6 removes support for IE 8 and 9 and these tags
are no longer necessary.

See: twbs/bootstrap#21483
alanorth added a commit to alanorth/hugo-theme-bootstrap4-blog that referenced this pull request Jan 8, 2017
Bootstrap v4 Alpha 6 removes support for IE 8 and 9 and these tags
are no longer necessary.

See: twbs/bootstrap#21483
alanorth added a commit to alanorth/hugo-theme-bootstrap4-blog that referenced this pull request Jan 8, 2017
Bootstrap v4 Alpha 6 removes support for IE 8 and 9 and these tags
are no longer necessary.

See: twbs/bootstrap#21483
alanorth added a commit to alanorth/hugo-theme-bootstrap4-blog that referenced this pull request Jan 8, 2017
Bootstrap v4 Alpha 6 removes support for IE 8 and 9 and these tags
are no longer necessary.

See: twbs/bootstrap#21483
alanorth added a commit to alanorth/hugo-theme-bootstrap4-blog that referenced this pull request Jan 9, 2017
Bootstrap v4 Alpha 6 removes support for IE 8 and 9 and these tags
are no longer necessary.

See: twbs/bootstrap#21483
alanorth added a commit to alanorth/hugo-theme-bootstrap4-blog that referenced this pull request Jan 9, 2017
Bootstrap v4 Alpha 6 removes support for IE 8 and 9 and these tags
are no longer necessary.

See: twbs/bootstrap#21483
@Herst
Copy link
Contributor

Herst commented Sep 5, 2017

Sorry for bumping this old PR but the following statement is not entirely correct and I can't let it stand:

no. HTML5 doctype has the exact same effect, without needing vendor-specific meta elements

This only applies to pages which aren't in the "Intranet" zone, see https://www.leapinggorilla.com/Blog/Read/1016/ie-ate-my-css---disabling-compatability-mode

What is true though is that the other reason for setting the meta tag in the past, the UI option to switch a page to compatibility mode is hidden per default (at least in IE11).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants