Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tooltip trigger must be called twice after call to hide #17702

Closed
wants to merge 1 commit into from

Conversation

jehhynes
Copy link

#16014 introduced a bug where a link must be clicked twice to show the tooltip after calling hide. Fixed by setting inState variables to false in the hide() method.

@twbs-savage
Copy link

Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: ef8bdd5f3231eee2445b28ca30975088bfac8bae
Build details: https://travis-ci.org/twbs-savage/bootstrap/builds/82203552

(Please note that this is a fully automated comment.)

@cvrebert
Copy link
Collaborator

You're presumably referring to bug #16732.

@cvrebert
Copy link
Collaborator

JavaScript changes must be accompanied by relevant unit test(s). See https://github.com/twbs/bootstrap/tree/master/js/tests#how-does-bootstraps-test-suite-work for info on how to add new unit test(s).

@jehhynes
Copy link
Author

Yes, I am referring to bug #16732.

Unit test has been added.

@twbs-savage
Copy link

Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: e4ca17151502cea933df1d11274d167395067d24
Build details: https://travis-ci.org/twbs-savage/bootstrap/builds/82637705

(Please note that this is a fully automated comment.)

@twbs-savage
Copy link

Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: 22f31a4
Build details: https://travis-ci.org/twbs-savage/bootstrap/builds/82957304

(Please note that this is a fully automated comment.)

@redbmk
Copy link
Contributor

redbmk commented Oct 14, 2015

@jehhynes Thanks for the fix and tests! Looks like the build is failing because of some trailing whitespace, preventing them from proceeding with the pull request.

@cvrebert
Copy link
Collaborator

(Strictly speaking, this is currently blocked waiting for @fat to code review it.)

@redbmk
Copy link
Contributor

redbmk commented Oct 14, 2015

Ah, I was just now getting around to looking at the bug and saw there was already this pull request. Looks like it's been here a couple weeks.

@gregblass
Copy link

+1 for the powers that be to release this! This is a pretty solid bug IMO.

@markbao
Copy link

markbao commented Jul 12, 2016

@jehhynes, would you be able to update this for 4.0, or can I adapt this PR to submit a new one? inState no longer exists and seems to be replaced by _activeTrigger.

e.g. this patches the issue:

$('body').on('hidden.bs.popover', function (e) {
    $(e.target).data("bs.popover")._activeTrigger.click = false;
});

@jehhynes
Copy link
Author

@markbao Please make this update and submit a new PR

@mdo
Copy link
Member

mdo commented Sep 5, 2016

Bootstrap 3 is no longer being officially developed or supported.

All work has moved onto our next major release, v4. As such, this issue or pull request is being closed as a "won't fix." For additional help and support, we recommend utilizing our community resources. Thanks for your understanding, and see you on the other side of v4!

<3,
@mdo and team

@mdo mdo closed this Sep 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants