Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples download "bootstrap-5.3.0-examples.zip" is missing file for dark mode "color-modes.js" #38746

Closed
2 tasks done
mark2016 opened this issue Jun 12, 2023 · 1 comment · Fixed by #38747
Closed
2 tasks done

Comments

@mark2016
Copy link

Prerequisites

Proposal

The Examples downloadable zip file found at
https://github.com/twbs/bootstrap/releases/download/v5.3.0/bootstrap-5.3.0-examples.zip
is missing JavaScript file "color-modes.js", which is referenced by the starter template (bootstrap-5.3.0-examples.zip\bootstrap-5.3.0-examples\starter-template). It is used for Dark/Light mode toggle.

A work-around is to copy the file from the Demo starter template at https://getbootstrap.com/docs/5.3/assets/js/color-modes.js

Would be a nice idea for convenience to include it in the download so that the Dark/Light mode examples work out of the box.

Motivation and context

It would allow the downloadable examples to work out of the box without any additional work.

@mark2016 mark2016 changed the title Exammples download "bootstrap-5.3.0-examples.zip" is missing file for dark mode "color-modes.js" Examples download "bootstrap-5.3.0-examples.zip" is missing file for dark mode "color-modes.js" Jun 12, 2023
@julien-deramond julien-deramond moved this to To do in v5.3.1 Jun 12, 2023
@julien-deramond julien-deramond moved this from To do to Needs review in v5.3.1 Jun 12, 2023
@julien-deramond
Copy link
Member

julien-deramond commented Jun 12, 2023

Thanks for reporting this issue @mark2016, good catch!
Created a PR to fix it: #38747

@julien-deramond julien-deramond moved this from Needs review to Done in v5.3.1 Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants