Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] missing warning for offcanvas dark classes #37853

Closed
3 tasks done
Tracked by #37549
bastienmoulia opened this issue Jan 10, 2023 · 1 comment · Fixed by #37861
Closed
3 tasks done
Tracked by #37549

[docs] missing warning for offcanvas dark classes #37853

bastienmoulia opened this issue Jan 10, 2023 · 1 comment · Fixed by #37861

Comments

@bastienmoulia
Copy link
Contributor

Prerequisites

Describe the issue

In the offcanvas doc, there is some dark classes without the warning to use data-bs-theme="dark".

Also in close button, the Heads up! is an info and not a warning.

Reduced test cases

https://getbootstrap.com/docs/5.3/components/offcanvas/#dark-offcanvas

https://getbootstrap.com/docs/5.3/components/close-button/#dark-variant

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Chrome

What version of Bootstrap are you using?

5.3.0

@julien-deramond
Copy link
Member

Thanks for reporting this issue @bastienmoulia and for reporting these inconsistencies. We'll try to uniformize everything in a PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants