Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with sass 1.56.0 #37424

Closed
3 tasks done
simPod opened this issue Nov 4, 2022 · 2 comments · Fixed by #37425
Closed
3 tasks done

Incompatible with sass 1.56.0 #37424

simPod opened this issue Nov 4, 2022 · 2 comments · Fixed by #37425
Labels

Comments

@simPod
Copy link
Contributor

simPod commented Nov 4, 2022

Prerequisites

Describe the issue

Sass v1.56.0 gives following warning:

Deprecation $weight: Passing a number without unit % (100) is deprecated.

To preserve current behavior: $weight * 1%

More info: https://sass-lang.com/d/function-units

Reduced test cases

Compile:

bootstrap/scss/_functions.scss 201:11  opaque()
bootstrap/scss/_functions.scss 175:18  contrast-ratio()
bootstrap/scss/_alert.scss 64:8        @import

What operating system(s) are you seeing the problem on?

macOS

What browser(s) are you seeing the problem on?

No response

What version of Bootstrap are you using?

5.2.2

@WilliamStam
Copy link

WilliamStam commented Nov 4, 2022

the poor bootstrap devs... sass keeps changing stuff and it keeps "breaking" bootstrap stuff. the team has my utmost respect for keeping up and not finding a bridge to jump off.

i came here cause of this issue to

for more info: https://sass-lang.com/documentation/breaking-changes/function-units#weight

The color.mix() function and color.invert() function have both historically ignored units in their $weight arguments, despite that argument conceptually representing a percentage. A future version of Sass will require the unit %.

Phase 1 (Dart Sass since 1.56.0)
Currently, Sass emits a deprecation warning if you pass a $weight with no units or with units other than % to color.mix() or color.invert().

Phase 2
In Dart Sass 2.0.0, color.mix() and color.invert() will throw errors if they’re passed a $weight with no unit or a non-% unit.

edit: looks like somone already did a PR woohooo #37425

@julien-deramond
Copy link
Member

Fixed by #37425.
Will be in v5.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants