Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dropdown-item has wrong border-radius #36329

Closed
3 tasks done
TomONeill opened this issue May 11, 2022 · 0 comments · Fixed by #36447
Closed
3 tasks done

dropdown-item has wrong border-radius #36329

TomONeill opened this issue May 11, 2022 · 0 comments · Fixed by #36447
Labels

Comments

@TomONeill
Copy link

Prerequisites

Describe the issue

In PR #27703, border-radius was added to fix the overflow. Then in #28127 there was an additional fix for when the dropdown padding is 0.

But the :first-child and :last-child selectors aren't right. They'll always be true since a .dropdown-item is always wrapped in a <li>.

image

Reduced test cases

$dropdown-padding-y: 0;
$dropdown-border-width: 0;
$dropdown-item-padding-y: 0.625rem;
$dropdown-item-padding-x: 0.75rem;
<ul class="dropdown-menu show">
  <li><a class="dropdown-item" href="#">Regular link</a></li>
  <li><a class="dropdown-item active" href="#" aria-current="true">Active link</a></li>
  <li><a class="dropdown-item" href="#">Another link</a></li>
</ul>

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Chrome

What version of Bootstrap are you using?

v5.1.3

@mdo mdo moved this to To do in v5.2.0-stable May 26, 2022
@mdo mdo closed this as completed in #36447 Jun 2, 2022
Repository owner moved this from To do to Done in v5.2.0-stable Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants