Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support <a> tag for close button? #26853

Closed
ysds opened this issue Jul 11, 2018 · 1 comment
Closed

Support <a> tag for close button? #26853

ysds opened this issue Jul 11, 2018 · 1 comment

Comments

@ysds
Copy link
Member

ysds commented Jul 11, 2018

The _close.scss contains .disabled class and text-decoration: none; and etc, it seems that close buttons support <a>.

&:not(:disabled):not(.disabled) {
@include hover-focus {
color: $close-color;
text-decoration: none;
opacity: .75;
}

However, there is no document or demo about <a> anywhere. Also the style of disabled close button issue will be fixed in v4.1.2 (#26654), it works well with <button>, but does not work with <a>. Demo: https://codepen.io/anon/pen/KBwaLv

If Bootstrap don't support a close button with <a>, we can clean up that CSS.

@ysds
Copy link
Member Author

ysds commented Jul 17, 2018

Closing this issue, I missed the next description in the .close.scss.

// If you want the anchor version, it requires href="#".

However, I have created #26899 for fix an issue of disabled <a>.

@ysds ysds closed this as completed Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant