Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a horizontal form validation example (check double label classes) #20983

Closed
caiquecastro opened this issue Oct 24, 2016 · 6 comments
Closed

Comments

@caiquecastro
Copy link
Contributor

The validation feedback for errors (.has-danger) has not been applied to the col-form.label.

screenshot from 2016-10-24 10-49-13

<div class="form-group has-danger">
    <label for="name" class="col-form-label">Name</label>
    <input type="text" id="name" name="name" class="form-control">
    <span class="help-block">The name field is required.</span>
</div>
@caiquecastro
Copy link
Contributor Author

I'd changed the class for the validation error message to .form-control-feedback, and it now works it, but the issue still remains for the input label. What's the correct class?

@caiquecastro
Copy link
Contributor Author

In other parts of the docs, there is a reference to .form-text class. What's the correct one: .form-text or .form-control-feedback?

@mdo
Copy link
Member

mdo commented Oct 25, 2016

If you're using v4, make sure you have the latest code—this should be working just fine with Alpha 5.

From our documentation:

@mdo mdo closed this as completed Oct 25, 2016
@caiquecastro
Copy link
Contributor Author

If I am using the form on the grid, as in the docs:

http://v4-alpha.getbootstrap.com/components/forms/#using-the-grid

Do I have to use both col-form-label and form-control-label classes on my label?

@mdo
Copy link
Member

mdo commented Oct 25, 2016

Ah, sorry, yes, right now you do. I think we need to revisit that. Reopening and retitling the issue so we can tackle that.

@mdo mdo reopened this Oct 25, 2016
@mdo mdo added this to the v4.0.0-alpha.6 milestone Oct 25, 2016
@mdo mdo changed the title has-danger and col-form-label Add a horizontal form validation example (check double label classes) Oct 25, 2016
@caiquecastro
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants