Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop JSCS? #20740

Closed
zlatanvasovic opened this issue Sep 18, 2016 · 3 comments
Closed

Drop JSCS? #20740

zlatanvasovic opened this issue Sep 18, 2016 · 3 comments
Labels
build js v4
Milestone
v4.0.0-alpha.6

Comments

@zlatanvasovic
Copy link
Contributor

ESLint has basically replaced JSCS completelly, almost all rules are supported and missing ones are in process of addition (eslint/eslint#5856). It may need some reviewing the used JSCS rules, but I think Bootstrap can stop using JSCS in v4.

Thoughts?
@cvrebert
Copy link
Collaborator

Once they finish porting the missing rules, SGTM.

@bardiharborow
Copy link
Member

I'm in the process of reviewing the build system anyway, so I'll volunteer to review and add the missing rules once upstream merges if that would help.

@bardiharborow bardiharborow mentioned this issue Oct 25, 2016
Merged
@bardiharborow bardiharborow mentioned this issue Jan 1, 2017
Merged
@bardiharborow bardiharborow added this to the v4.0.0-alpha.6 milestone Jan 1, 2017
@bardiharborow
Copy link
Member

Fixed by #21480.

@mdo mdo mentioned this issue Jan 1, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build js v4
Projects
None yet
Milestone
v4.0.0-alpha.6
Development

No branches or pull requests
3 participants
@cvrebert @bardiharborow @zlatanvasovic