Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRTs sometimes roll across text #139

Open
slifty opened this issue Jul 3, 2021 · 0 comments
Open

SRTs sometimes roll across text #139

slifty opened this issue Jul 3, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@slifty
Copy link
Member

slifty commented Jul 3, 2021

Bug

Current Behavior

Sometimes SRT buffers seem to write over the previous line, instead of starting from scratch:

image

I originally thought this was a symptom of the improvement need described in #133, but upon looking closer, it's clear that there are two sentences being merged together:

GROUP THAT WENT FROM THE PRESS
BRIEFING WHERE THEY MET BEFORE

Expected Behavior

It shouldn't merge sentences like that! Some buffer somwhere clearly needs to be cleared out.

Possible Solutions

It is possible this is related to timestamp / positions being out of order. I believe that the CCExtractor payloads may calculate positions based on the CCExtractor outputs instead of the payloads.

I suspect this is not a CaptionExtractorAppliance bug but rather an SrtGeneratorAppliance bug.

Related Issues

Possibly related to issue #133
Possibly related to the fix for #130, as that was a recent change that impacted calculated positions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant