Local checkImages function instead of triggering events on the container #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
February 21, 2012 14:56
…gger events on elements not owned by the plugin; Fixes #18 since window.onscroll is never called by the plugin anymore
…, fixes alternate containers that are not in the viewport
…ommonly-called functions
|
Should have opened with specific diff instead of against master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #18. Instead of triggering an event on the container, this moves the image checking into its own function. That function is called where events were previously triggered.
Resizing the window no longer scrolls to the top of the window in jQuery <1.7.
The plugin should only trigger its own events so other code doesn't receive an erroneous
onscrollwhen the window wasn't actually scrolled. Now the plugin only triggersappear.