Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover clippy test. #34

Open
tushushu opened this issue Aug 20, 2022 · 0 comments
Open

Recover clippy test. #34

tushushu opened this issue Aug 20, 2022 · 0 comments
Labels
Milestone

Comments

@tushushu
Copy link
Owner

The clippy test shows the errors below, which is not expected:

error: deref on an immutable reference
  --> src/lib.rs:80:34
   |
80 | fn hash128_x[64](https://github.com/tushushu/murmurust/runs/7928640580?check_suite_focus=true#step:6:65)(_py: Python, key: &str, seed: u32, signed: bool) -> Py<PyAny> {
   |                                  ^ help: if you would like to reborrow, try removing `&*`: `&`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref

This is going to be fixed by PyO3/pyo3#2555. Currently, I have to disable the clippy errors, and when PYO3 0.17.0 released, we need change it back.

@tushushu tushushu added this to the 2.0.0 milestone Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant